fix: escape single quotes, raw text parsing, input validation#73
Open
dannywillems wants to merge 3 commits intomasterfrom
Open
fix: escape single quotes, raw text parsing, input validation#73dannywillems wants to merge 3 commits intomasterfrom
dannywillems wants to merge 3 commits intomasterfrom
Conversation
Add single-quote escaping (') to Element::render_to to prevent XSS when attribute values contain single quotes and are later placed in single-quoted contexts. Closes #59
Add a RawText tokenizer state that prevents content inside script, style, textarea, and title elements from being parsed as HTML. The tokenizer now scans for the matching end tag before resuming normal HTML parsing. Closes #53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
') in DOM attribute rendering to prevent XSS in single-quoted contextsRawTexttokenizer state for<script>,<style>,<textarea>, and<title>elements so their content is not parsed as HTMLTest plan
#[should_panic]) for tag and attribute names-D warnings)Closes #59
Closes #53
Closes #25
Closes #27