Skip to content

fix: resolve all critical parser and macro issues #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannywillems merged 4 commits into from
Feb 8, 2026
Merged

fix: resolve all critical parser and macro issues #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4be0cf6
fix: rewrite tree builder fragment mode and pop_until
dannywillems Feb 8, 2026
a721d49
fix: emit compile error when for-loop body has multiple children
dannywillems Feb 8, 2026
12d83bb
fix: remove Rb/Rtc from macro to_pascal_case
dannywillems Feb 8, 2026
9feedfb
test: add comprehensive tree builder tests
dannywillems Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions crates/ironhtml-macro/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ struct ForLoop {

impl Parse for ForLoop {
fn parse(input: ParseStream) -> Result<Self> {
input.parse::<Token![for]>()?;
let for_token: Token![for] = input.parse()?;
let pat = syn::Pat::parse_single(input)?;
input.parse::<Token![in]>()?;
input.parse::<Token![#]>()?;
Expand All @@ -329,6 +329,13 @@ impl Parse for ForLoop {
children.push(content.parse()?);
}

if children.len() != 1 || !matches!(children.first(), Some(Node::Element(_))) {
return Err(syn::Error::new(
for_token.span,
"for loop body must contain exactly one element",
));
}

Ok(Self {
pat,
expr,
Expand Down Expand Up @@ -464,8 +471,6 @@ fn to_pascal_case(s: &str) -> String {
"Em" => "Em".to_string(),
"Rp" => "Rp".to_string(),
"Rt" => "Rt".to_string(),
"Rb" => "Rb".to_string(),
"Rtc" => "Rtc".to_string(),
"Wbr" => "Wbr".to_string(),
"Kbd" => "Kbd".to_string(),
"Pre" => "Pre".to_string(),
Expand Down
Loading