Skip to content

Improve test assertions to verify field values#58

Merged
dannywillems merged 1 commit intomainfrom
fix/41-better-assertions
Feb 8, 2026
Merged

Improve test assertions to verify field values#58
dannywillems merged 1 commit intomainfrom
fix/41-better-assertions

Conversation

@dannywillems
Copy link
Contributor

Summary

  • Assert actual field values (names, descriptions, subdomain counts) instead of just checking len() and is_success()
  • Covers test_get_plugins_success, test_get_subdomains_success, test_get_plugins_unauthorized

Test plan

  • All 70 tests pass

Closes #41

Assert actual field values in test_get_plugins_success (plugin
names and descriptions), test_get_subdomains_success (subdomain
names and IP counts), and test_get_plugins_unauthorized (status
code).

Closes #41
@dannywillems dannywillems merged commit af3f58c into main Feb 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve test assertions: verify field values, not just success

1 participant