Fixes spellings and some sentence structures.#42
Open
ch4nd4n wants to merge 2 commits intoLeaVerou:old-mainfrom
Open
Fixes spellings and some sentence structures.#42ch4nd4n wants to merge 2 commits intoLeaVerou:old-mainfrom
ch4nd4n wants to merge 2 commits intoLeaVerou:old-mainfrom
Conversation
✅ Deploy Preview for leaverou ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LeaVerou
requested changes
Nov 13, 2023
Owner
LeaVerou
left a comment
LeaVerou
left a comment
There was a problem hiding this comment.
Hey, thanks for taking the time! See comments, I'm fine with the rest.
|
|
||
| <figcaption> | ||
|
|
||
| The new GitHub commenting UI, unfocused. |
Owner
There was a problem hiding this comment.
The original was correct here: it is depicting the new UI, when it is unfocused.
|
|
||
| <figcaption> | ||
|
|
||
| The new GitHub commenting UI, focused. Am I the only one that expected the focus outline to also follow the irregular shape? |
| </figure> | ||
|
|
||
| While definitely more cluttered, its main UI elements were much more recognizable: | ||
| there is a text field, indicated by the rounded rectangle, and tabs, indicated by the light gray border around the active tab. |
Owner
There was a problem hiding this comment.
As you pointed out, gray is perfectly valid US English.
| Heck, there’s nothing even indicating whether a symbol produces sound or not! | ||
| Demanding a lot of [knowledge in the head](https://medium.com/@matthewraychiang/doet-knowledge-in-the-head-and-in-the-world-64f901627eb3) | ||
| is not a problem in itself; it’s a common tradeoff when efficiency is higher priority than learnability. | ||
| is not a problem in itself; it’s a common tradeoff when efficiency is a higher priority than learnability. |
Author
|
Hello I will be busy with office. Will try to go over this in the evening.
…On Mon, 13 Nov 2023 at 11:46 PM, Lea Verou ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hey, thanks for taking the time! See comments, I'm fine with the rest.
------------------------------
In blog/2023/minimalist-affordances/index.md
<https://github.com/LeaVerou/lea.verou.me/pull/42#discussion_r1391294130>:
> @@ -42,7 +42,7 @@ Look at how the text area smoothly blends with the tab, creating an irregular an
<figcaption>
-The new GitHub commenting UI, unfocused.
The original was correct here: it is depicting the new UI, when it is
unfocused.
------------------------------
In blog/2023/minimalist-affordances/index.md
<https://github.com/LeaVerou/lea.verou.me/pull/42#discussion_r1391294367>:
> @@ -52,7 +52,7 @@ The new GitHub commenting UI, unfocused.
<figcaption>
-The new GitHub commenting UI, focused. Am I the only one that expected the focus outline to also follow the irregular shape?
See above
------------------------------
In blog/2023/minimalist-affordances/index.md
<https://github.com/LeaVerou/lea.verou.me/pull/42#discussion_r1391295063>:
> @@ -72,7 +72,7 @@ The old GitHub commenting UI (focused only — I couldn’t find an unfocused on
</figure>
While definitely more cluttered, its main UI elements were much more recognizable:
-there is a text field, indicated by the rounded rectangle, and tabs, indicated by the light gray border around the active tab.
As you pointed out, gray is perfectly valid US English.
------------------------------
In blog/2023/minimalist-affordances/index.md
<https://github.com/LeaVerou/lea.verou.me/pull/42#discussion_r1391295913>:
> @@ -196,7 +196,7 @@ Yet *absolutely nothing* in their representation signifies this.
You just have to learn it.
Heck, there’s nothing even indicating whether a symbol produces sound or not!
Demanding a lot of [knowledge in the ***@***.***/doet-knowledge-in-the-head-and-in-the-world-64f901627eb3)
-is not a problem in itself; it’s a common tradeoff when efficiency is higher priority than learnability.
+is not a problem in itself; it’s a common tradeoff when efficiency is a higher priority than learnability.
Both seem correct to me?
—
Reply to this email directly, view it on GitHub
<https://github.com/LeaVerou/lea.verou.me/pull/42#pullrequestreview-1727606772>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATW2BIHQECE77ASIW3BO3YEI6ENAVCNFSM6AAAAAA7IW2YFKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMRXGYYDMNZXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that grey/gray is a US/UK thing. You may want to ignore that.