Add Stability-Based Coloring to Embedding Visualization#79
Open
Add Stability-Based Coloring to Embedding Visualization#79
Conversation
Collaborator
|
This makes sense to me! I think the main thing I would add is an additional color specifically for S.U.N. or M.S.U.N. crystals. Separately, although it is likely out of scope for this pr, it would be useful to only plot crystals that fall into these different buckets (stable, metastable, sun, msun) rather than plotting all generated crystals. |
andaero
approved these changes
Nov 20, 2025
Collaborator
andaero
left a comment
There was a problem hiding this comment.
Left comments above already! Otherwise lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the embedding visualization so that structures are color-coded by their stability classification (stable, metastable, unstable). This enhances the interpretability of the embedding view and allows potential clustering by stable and metastable structures.
Details
Structureobjects include stability information within theirpropertiesattribute.Impact
These changes improve the clarity and utility of the embedding plots, especially when comparing or filtering structures by stability. Users will need to ensure that stability metadata is available for each structure before generating visualizations.