Add chamfer to bin magnet cutout#180
Open
colinasmith wants to merge 3 commits intoLe0Michine:masterfrom
Open
Conversation
offset: A distance offset on the extrude taperAngle: A taper angle on the extrude The default values of these parameters ensure that existing usage of this function is not affected.
To make friction fit magnet insertion more forgiving. This adds two chamfer parameters to the bin magnet cutout. In they UI they are: Magnet cutout chamfer XY Magnet cutout chamfer Z If either is set to 0.0, which is the default, then the chamfer is turned off. I use 0.2 mm for XY and 1.0 for Z.
The UI state initialization logic caused saved user settings to be overwritten by hardcoded defaults upon command startup because it applied hardcoded defaults after loading the saved settings. This change corrects the behavior by: 1. Modifying initValue to only set a default if a value is not already present in the state. 2. Reordering initDefaultUiState to load saved settings before applying hardcoded defaults. This ensures that saved user preferences are correctly loaded and respected, and that newly added parameters (like the magnet chamfers) are properly initialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current design, the magnet hole diameter needs to be very precisely dialed in to get the right friction fit. This pull request adds a chamfer that makes the hole diameter more forgiving. There are two parameters controlling the chamfer in the XY and Z directions. They default to 0 mm. If either is 0 mm, no chamfer is added.
Because bins are made so much more often, I only added this functionality to the bin generator. It could also be added to the baseplate generator.