fix(db): detect auto_increment for SQLite INTEGER PRIMARY KEY#44
Merged
fix(db): detect auto_increment for SQLite INTEGER PRIMARY KEY#44
Conversation
…CREMENT keyword in SQLite export In SQLite, INTEGER PRIMARY KEY columns are implicitly ROWID aliases and auto-incrementing, regardless of whether the AUTOINCREMENT keyword is present in the DDL. The introspector previously only detected auto_increment when the explicit AUTOINCREMENT keyword was found in the CREATE TABLE SQL, causing the attribute to be lost during export. Fixes #28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLiteの
INTEGER PRIMARY KEYカラムのauto_increment属性がstrata export時に失われる問題を修正。SQLiteでは
INTEGER PRIMARY KEYは暗黙的にROWIDのエイリアスとなり自動増分するが、イントロスペクターは明示的なAUTOINCREMENTキーワードがDDLに含まれている場合のみauto_incrementを検出していた。Strataのgenerate_create_tableはAUTOINCREMENTキーワードを生成しないため、generate→apply→exportのラウンドトリップでauto_increment: trueが常に失われていた。修正内容:
INTEGER型かつPRIMARY KEYのカラムであれば、AUTOINCREMENTキーワードの有無に関わらずauto_increment: trueとして検出するよう変更。Related Issue
Fixes #28
Type of Change
Test Plan
Checklist
cargo fmtandcargo clippycargo test)