fix(db): preserve DOUBLE type in SQLite export#43
Merged
Conversation
…to FLOAT SQLite's type mapper was converting both FLOAT and DOUBLE to REAL in SQL generation, then mapping REAL back to FLOAT during introspection, losing the DOUBLE distinction. Now DOUBLE is preserved as DOUBLE in generated SQL (SQLite accepts any type name with REAL affinity), and DOUBLE declared types are correctly parsed back to ColumnType::DOUBLE. Fixes #27 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite の型マッパーが FLOAT と DOUBLE の両方を
REALに変換していたため、エクスポート時にREAL→FLOATへマッピングされ、DOUBLE カラムが FLOAT として出力されていた。修正内容:
format_sql_type: DOUBLE →DOUBLE（SQLite は任意の型名を受け入れ、REAL アフィニティとして扱う）parse_sql_type:DOUBLE宣言型 →ColumnType::DOUBLEへ正しくマッピングRelated Issue
Fixes #27
Type of Change
Test Plan
Checklist
cargo fmtandcargo clippycargo test)