[perf]: backport changes from thunder perf hackathon #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-L2L
requested changes
Sep 18, 2025
Ash-L2L
requested changes
Sep 23, 2025
A-Manning
approved these changes
Sep 23, 2025
Ash-L2L
approved these changes
Sep 23, 2025
Ash-L2L
pushed a commit
that referenced
this pull request
Oct 14, 2025
* [perf]: backport changes from thunder perf hackathon * [misc] Fix std dep order, add comments * [cli] remove mimalloc from cli * [fix] smallvec usage * [misc] Add comments for LMDB flags * [fix] Switch to Borsh and add small test for OutpointKey * [fix] make in/out tracking explicit as per suggestion * [fix] Adjust import ordering * [fix] clarify counts() use, rm into_parts() and explicit deconstruct * [fix] explicit From
Ash-L2L
pushed a commit
to giaki3003/thunder-rust
that referenced
this pull request
Oct 14, 2025
* [perf]: backport changes from thunder perf hackathon * [misc] Fix std dep order, add comments * [cli] remove mimalloc from cli * [fix] smallvec usage * [misc] Add comments for LMDB flags * [fix] Switch to Borsh and add small test for OutpointKey * [fix] make in/out tracking explicit as per suggestion * [fix] Adjust import ordering * [fix] clarify counts() use, rm into_parts() and explicit deconstruct * [fix] explicit From
Ash-L2L
pushed a commit
that referenced
this pull request
Oct 14, 2025
* [perf]: backport changes from thunder perf hackathon * [misc] Fix std dep order, add comments * [cli] remove mimalloc from cli * [fix] smallvec usage * [misc] Add comments for LMDB flags * [fix] Switch to Borsh and add small test for OutpointKey * [fix] make in/out tracking explicit as per suggestion * [fix] Adjust import ordering * [fix] clarify counts() use, rm into_parts() and explicit deconstruct * [fix] explicit From
Ash-L2L
pushed a commit
that referenced
this pull request
Oct 14, 2025
* [perf]: backport changes from thunder perf hackathon * [misc] Fix std dep order, add comments * [cli] remove mimalloc from cli * [fix] smallvec usage * [misc] Add comments for LMDB flags * [fix] Switch to Borsh and add small test for OutpointKey * [fix] make in/out tracking explicit as per suggestion * [fix] Adjust import ordering * [fix] clarify counts() use, rm into_parts() and explicit deconstruct * [fix] explicit From
Ash-L2L
pushed a commit
that referenced
this pull request
Oct 14, 2025
* [perf]: backport changes from thunder perf hackathon * [misc] Fix std dep order, add comments * [cli] remove mimalloc from cli * [fix] smallvec usage * [misc] Add comments for LMDB flags * [fix] Switch to Borsh and add small test for OutpointKey * [fix] make in/out tracking explicit as per suggestion * [fix] Adjust import ordering * [fix] clarify counts() use, rm into_parts() and explicit deconstruct * [fix] explicit From
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds misc perf improvements which have been already merged (or partially merged) into upstream. This includes
WRITE_MAP, MAP_ASYNC, NO_SYNC, NO_META_SYNC, NO_READ_AHEAD, NO_TLS)OutPointKeyand ordered apply to coalesce writesOutPointKey keysfor LMDB (both node and wallet DBs)mimallocv3 as a global allocator