Skip to content

[IMP] Add Docs to helper objs & fix sphinx syntax#7

Merged
lasley merged 1 commit intomasterfrom
hotfix/master/docblocks
Dec 21, 2016
Merged

[IMP] Add Docs to helper objs & fix sphinx syntax#7
lasley merged 1 commit intomasterfrom
hotfix/master/docblocks

Conversation

@lasley
Copy link
Member

@lasley lasley commented Dec 21, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 21, 2016

Current coverage is 100% (diff: 100%)

Merging #7 into master will not change coverage

@@           master    #7   diff @@
===================================
  Files          13    13          
  Lines         129   130     +1   
  Methods         0     0          
  Messages        0     0          
  Branches        5     5          
===================================
+ Hits          129   130     +1   
  Misses          0     0          
  Partials        0     0          

Sunburst

Diff Coverage File Path
•••••••••• 100% cfssl/models/policy_auth.py
•••••••••• 100% cfssl/models/config_client.py
•••••••••• 100% cfssl/models/policy_use.py
•••••••••• 100% cfssl/models/certificate_request.py
•••••••••• 100% cfssl/cfssl.py
•••••••••• 100% cfssl/models/config_key.py
•••••••••• 100% cfssl/models/policy_sign.py
•••••••••• 100% cfssl/models/host.py
•••••••••• 100% cfssl/models/subject_info.py
•••••••••• 100% cfssl/defaults.py

Review all 11 files changed

Powered by Codecov. Last update 693ebc2...ce5556b

@coveralls
Copy link

Coverage Status

Coverage decreased (-82.0%) to 18.033% when pulling d1e937f86e03ee7e80926e2ef6666e1951aa98c0 on hotfix/master/docblocks into 693ebc2 on master.

@lasley
Copy link
Member Author

lasley commented Dec 21, 2016

Well crap the new Travis script doesn't fail when it's broken - https://travis-ci.org/LasLabs/python-cfssl/jobs/185644614#L276

How useless 😆

@lasley lasley removed the request for review from tedsalmon December 21, 2016 01:25
@lasley lasley assigned lasley and unassigned tedsalmon Dec 21, 2016
@lasley lasley force-pushed the hotfix/master/docblocks branch from d1e937f to 092e033 Compare December 21, 2016 01:27
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 95.385% when pulling 092e0333b47498c8d7fa2b7d128934e29b23fe43 on hotfix/master/docblocks into 693ebc2 on master.

@lasley lasley force-pushed the hotfix/master/docblocks branch from 092e033 to 3780bcf Compare December 21, 2016 01:33
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 99.231% when pulling 3780bcf8acd34d58743a1476747389636154dd76 on hotfix/master/docblocks into 693ebc2 on master.

Copy link
Contributor

@tedsalmon tedsalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Nice docs :)

One minor spelling mistake ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/remote/remotes

@tedsalmon
Copy link
Contributor

Awh crap. I loaded this before you switched it back to WIP. My bad!

@lasley lasley force-pushed the hotfix/master/docblocks branch from 3780bcf to 1350f92 Compare December 21, 2016 01:36
@lasley
Copy link
Member Author

lasley commented Dec 21, 2016

Meh no worries, I'll just merge after making my few fixes for the build + your's. I noticed a bug but didn't update the tests.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1350f92905fbc7df894b094f0ce11c7ee40dbe9a on hotfix/master/docblocks into 693ebc2 on master.

@lasley lasley force-pushed the hotfix/master/docblocks branch from 1350f92 to 17a8bcf Compare December 21, 2016 01:38
@lasley
Copy link
Member Author

lasley commented Dec 21, 2016

Alright assuming this passes, I'll merge. Looking forward to seeing what this looks like in the docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 17a8bcf8b2a22ce38951cd00d6ff5dd936169f69 on hotfix/master/docblocks into 693ebc2 on master.

@lasley lasley force-pushed the hotfix/master/docblocks branch from 17a8bcf to ce5556b Compare December 21, 2016 01:41
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ce5556b on hotfix/master/docblocks into 693ebc2 on master.

@lasley lasley merged commit 329e157 into master Dec 21, 2016
@lasley lasley deleted the hotfix/master/docblocks branch December 21, 2016 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants