Various fixes and small enhancements#20
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 100% 94.28% -5.72%
==========================================
Files 13 13
Lines 131 140 +9
Branches 5 8 +3
==========================================
+ Hits 131 132 +1
- Misses 0 8 +8
|
a84ca40 to
2a4ed8a
Compare
ba71156 to
c6150b9
Compare
|
I'll fix tests tomorrow |
In some use case, it's easier to pass native structures (dict, string, ...) instead of domain objects (CertificateRequest, SubjectInfo, ...)
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 14 +1
Lines 131 157 +26
Branches 5 12 +7
=====================================
+ Hits 131 157 +26
|
|
I've bring back 100% code coverage ! :) I think it's ready to merge. I've made another change today to allow raw API data structures instead of Domain objects (RequestCertificate, Host, SubjectInfo, and so one). They can now be replaced with string or dict, this will also work. |
|
Maybe you could add Python 3 version in Could you perform a pipy release after merge ? |
Good idea; I like.
I noticed your change in 2a4ed8a and created #21 to make the Travis change. Thanks for that!
Definitely |
This fix some issues that I think are mainly related to changes in dependencies and CFSSL api since this library was initialy written.