[Feature] Scroll and Open specific log entry#58
Closed
makss wants to merge 2 commits intoLaravel-Backpack:mainfrom
Closed
[Feature] Scroll and Open specific log entry#58makss wants to merge 2 commits intoLaravel-Backpack:mainfrom
makss wants to merge 2 commits intoLaravel-Backpack:mainfrom
Conversation
Contributor
|
Hey @makss thanks for the PR 🙏 Sorry it took some time to get back here! Indeed I think it's a very clever solution to allow developer to share links to specific log entries. 👏 I am ok with the JS part, but I am afraid I don't agree with html changes. Why do we need them ? To re-order the logs ? If that's the case woudn't it be better to create some extra configuration like Cheers |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
It is not possible to link to a specific entry in the log file.
AFTER - What is happening after this PR?
Now you can send a link to a specific entry in the log file to someone by mail or add it to a bug report.
HOW
How did you achieve that, in technical terms?
The log file output uses reverse sorting. Therefore, reverse numbering of entries in the log file was also made. Adding new entries will not break previous links.