Allow laminas-diactoros 3, so we can use this on PHP 8.5, a…#16
Open
bdsl wants to merge 1 commit intoLansoweb:masterfrom
Open
Allow laminas-diactoros 3, so we can use this on PHP 8.5, a…#16bdsl wants to merge 1 commit intoLansoweb:masterfrom
bdsl wants to merge 1 commit intoLansoweb:masterfrom
Conversation
…lso move from require to require-dev See release notes of diactoros 3: https://github.com/laminas/laminas-diactoros/releases/tag/3.0.0 > For consumers, this version should be entirely backwards compatible in usage. For those extending > our classes, you will only run into issues when extending implementations of the above interfaces. But actually searching `diactoros` in the codebase here I see it's only actually used in tests not in the src directory, so what's used here shouldn't affect downstream consumers of the library anyway.
bdsl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lso move from require to require-dev
See release notes of diactoros 3: https://github.com/laminas/laminas-diactoros/releases/tag/3.0.0
But actually searching
diactorosin the codebase here I see it's only actually used in tests not in the src directory, so what's used here shouldn't affect downstream consumers of the library anyway.