blank isReverse removed, backlink duplicates fixed #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptsefton
reviewed
Dec 10, 2025
ptsefton
left a comment
ptsefton
left a comment
There was a problem hiding this comment.
left a comment - is there a better way to do this?
| const target = this.crate.getEntity(i['@id']); | ||
| if (target) { | ||
| this.crate.addValues(target, p1, item); | ||
| // Check whether target already has a backlink to `item` |
There was a problem hiding this comment.
is this the best place to put this? How are blanks getting in there in the first place. would be better to NOT do another complete pass if you can fix it further upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.