Add an S3 backend #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stat was only used by exists. Exists makes more sense in an S3 context and stat doesn't.
Due to the way S3 works you need to await that the stream is completed and then also await the S3 API call as it users multipart uploads and needs to finalise things before it's done.
We pass a storeConfig and helper to the tests. The storeConfig is because for S3 we use local S3 server when testing so we need to pass in an s3 object to the tests (similar to the fs object than can be used for the filesystem backing). We also pass a helper in to the tests. This helper has one method right now getFile. It is used to get raw objects from the repository. The current tests assume a filesystem so the helper allows the tests to fetch from whatever the backend store happens to be.
On S3 it comes back as a buffer.
From what I can tell this logic was the wrong way around. I don't think it was caught by the tests since ocfl-fs implements readFile itself.
importFile was reading the source using the store, while this happens to work for ocfl-fs it won't for S3. As importFile source should be the the local filesystem, not the catalog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.