Feature: Added SystemInformation and associated helpers#121
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new OSVersion struct and extends the ApplicationDataStorageHelper with additional functionality while updating global usings to support new Windows system features.
- Added OSVersion struct with properties and a ToString override.
- Extended ApplicationDataStorageHelper with composite value support and file/folder operations.
- Updated GlobalUsings to include additional Windows.System and Windows.Storage namespaces.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/extensions/Riverside.Extensions.Versioning/OSVersion.cs | Adds a new immutable struct to represent OS version details. |
| src/core/Riverside.Toolkit.Helpers/ObjectStorage/ApplicationDataStorageHelper.cs | Implements helper methods to facilitate file and settings storage operations, including composite settings. |
| eng/MultiTarget/GlobalUsings.cs | Updates the global usings with additional namespaces for system profiles and storage functionality. |
src/core/Riverside.Toolkit.Helpers/ObjectStorage/ApplicationDataStorageHelper.cs
Show resolved
Hide resolved
Lamparter
commented
Mar 15, 2025
Lamparter
force-pushed
the
lamparter/sysinfo
branch
from
92261ca to
80058cf
Compare
Owner
Author
|
Good enough for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
SystemInformationhelper #119Steps used to test these changes