Make fw_prepare pick the right cloudOS IPSW automatically#238
Open
felipejfc wants to merge 1 commit intoLakr233:mainfrom
Open
Make fw_prepare pick the right cloudOS IPSW automatically#238felipejfc wants to merge 1 commit intoLakr233:mainfrom
felipejfc wants to merge 1 commit intoLakr233:mainfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
I updated
fw_prepare.shso it fills inCLOUDOS_SOURCEautomatically when I don't pass one.Instead of falling back to a single hardcoded cloudOS URL, it now:
ComputeModule14,2)I kept the manual override path the same, so
--cloudos-source/CLOUDOS_SOURCEstill win if I want to pin a specific cloudOS IPSW.Why
I don't want to keep matching the cloudOS IPSW by hand every time I change the iPhone firmware. This makes the default path do the right thing and avoids mismatching the PCC firmware.
Quick check
bash -n scripts/fw_prepare.sh23D*iPhone build resolves to downloadable cloudOS23D128on AppleDB