Skip to content

Comments

Updating code formatting and consistency#94

Open
Murat65536 wants to merge 8 commits intomainfrom
formatting
Open

Updating code formatting and consistency#94
Murat65536 wants to merge 8 commits intomainfrom
formatting

Conversation

@Murat65536
Copy link
Contributor

@Murat65536 Murat65536 commented Sep 13, 2025

Pull Request


Issue Number

Comments

Added a lot of finals since they weren't present in too many places for some reason. Also some general clean-up.

@reediculous456 reediculous456 changed the title Introduce some proper formatting. Nothing too crazy. Updating code formatting and consistency Sep 13, 2025
@reediculous456 reediculous456 moved this from Backlog to Back to developer in 2025 Robot Project Sep 13, 2025
@Murat65536 Murat65536 moved this from Back to developer to Mentor review in 2025 Robot Project Sep 13, 2025
@Murat65536
Copy link
Contributor Author

Also, WPILIB is set to change constants from Hungarian notation to caps in 2027. This also affects the docs (assuming they update) and I believe the reason we did Hungarian notation was because of how it was in the docs. Probably not something to do right now but this would be pretty nice for 2027. Especially since we could stop using ! in the UMLs and just have caps represent final.

@reediculous456
Copy link
Member

Also, WPILIB is set to change constants from Hungarian notation to caps in 2027. This also affects the docs (assuming they update) and I believe the reason we did Hungarian notation was because of how it was in the docs. Probably not something to do right now but this would be pretty nice for 2027. Especially since we could stop using ! in the UMLs and just have caps represent final.

This makes me so happy. Yes we should update to match this moving forward

@Murat65536
Copy link
Contributor Author

So based on the conversation with Michael where he stated that he liked for everything to be verbose, would we be fine with setting all the unchanged parameters (so basically all of them) to final as well?

@Murat65536
Copy link
Contributor Author

And based on this, even Oracle seems to think that not prefixing enum constructors with private is appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Mentor review

Development

Successfully merging this pull request may close these issues.

2 participants