Conversation
added 6 commits
March 11, 2024 23:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some quick fixes I could make upon a quick examination. I didn't yet give it a deep dive, but my VSCode IDE highlighted the typos so they were easy to fix.
We use flask servers at work regularly, and I have used openCV so this is all familiar. I'm interested to see how well this works. I also added a requirements file which lists the python dependencies which is a good habit to get into. It's common practice to generate these using "pip freeze" once you find a combination that works, but I don't really like that practice.
I don't see anything here the standard apriltag library couldn't do, but maybe there's some good reason to use machine learning?
https://pypi.org/project/apriltag/