Code cleanup & modernization #150
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update regex and logic to support version 1.0 of the game. - Use a single regex string to capture both chat and GMSG strings instead of separately handling both. - To handle the lack of player names in message IDs, maintain an index of entity IDs to player names. Update this on startup with the 'lpi' command and whenever new players join through the 'PlayerSpawnedInWorld' message.
Bring variable definitions up to modern times. Removes ambiguity over which variables are reassigned.
* Update telnet-client to 2.2.1. Fixes issues with message spam due to the client sending repeated data. * Update ws to clear vulnerability
Fix the 'unknown player' warning erroneously being logged every time a GMSG is sent.
Fix command errors due to const in a for loop.
Revert the workaround for player names as the new updates no-longer need this.
* Migrate from CommonJS to ESM. * Clean up DemoClient class definitions and exports. * Use default exports for lib/ scripts. * Drop support for running without semver-compare for now.
Replace the telnet-client package with a custom provider using the Node.js Net API. Remove handling designed to work around the quirks in the telnet-client package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a behind-the-scenes modernization and patch-up for 2025.