-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate dependenvy of CD packages in favor of DV ones #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis PR systematically migrates dependency packages across the monorepo from deprecated libraries ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
requirements.txt (1)
1-1: Consider the version constraint for cnpj-dv.The dependency changed from
cnpj-cd>=1.0.1tocnpj-dv>=1.0.0, which lowers the minimum version requirement. This might be intentional ifcnpj-dv1.0.0 is the first stable release, but verify this aligns with your compatibility requirements.Additionally, consider adding upper version bounds (e.g.,
cnpj-dv>=1.0.0,<2.0.0) for consistency with the constraints inpackages/cnpj-gen/pyproject.toml.packages/cnpj-gen/CHANGELOG.md (1)
3-10: Consider whether this warrants a minor version bump.The changelog documents the migration from
cnpj-cdtocnpj-dvas version 1.0.2 (patch). However, since this changes the dependency requirements for consumers who might havecnpj-cdbut notcnpj-dv, consider whether this should be a minor version bump (1.1.0) instead.According to semantic versioning, a patch version should be for backward-compatible bug fixes. While the API hasn't changed, the dependency change could affect installation and compatibility.
packages/cnpj-val/CHANGELOG.md (1)
3-10: Consider whether this warrants a minor version bump.Similar to
cnpj-gen, this dependency migration is documented as a patch version (1.0.2). Consider whether changing dependency requirements warrants a minor version bump (1.1.0) instead, as downstream consumers will need to havecnpj-dvavailable.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
packages/cnpj-gen/CHANGELOG.mdpackages/cnpj-gen/pyproject.tomlpackages/cnpj-gen/src/cnpj_gen/cnpj_generator.pypackages/cnpj-val/CHANGELOG.mdpackages/cnpj-val/pyproject.tomlpackages/cnpj-val/src/cnpj_val/cnpj_validator.pypackages/cpf-gen/CHANGELOG.mdpackages/cpf-gen/README.mdpackages/cpf-gen/pyproject.tomlpackages/cpf-gen/src/cpf_gen/cpf_generator.pypackages/cpf-val/CHANGELOG.mdpackages/cpf-val/README.mdpackages/cpf-val/pyproject.tomlpackages/cpf-val/src/cpf_val/cpf_validator.pyrequirements.txt
🧰 Additional context used
🧬 Code graph analysis (3)
packages/cnpj-val/src/cnpj_val/cnpj_validator.py (1)
packages/cnpj-dv/src/cnpj_dv/cnpj_check_digits.py (1)
CnpjCheckDigits(13-147)
packages/cpf-gen/src/cpf_gen/cpf_generator.py (1)
packages/cpf-dv/src/cpf_dv/cpf_check_digits.py (1)
CpfCheckDigits(14-154)
packages/cnpj-gen/src/cnpj_gen/cnpj_generator.py (1)
packages/cnpj-dv/src/cnpj_dv/cnpj_check_digits.py (1)
CnpjCheckDigits(13-147)
🔇 Additional comments (16)
packages/cpf-val/CHANGELOG.md (1)
3-10: LGTM! Clear migration documentation.The changelog entry properly documents the dependency migration from
cpf-cdtocpf-dvwith clear version information.packages/cpf-gen/CHANGELOG.md (1)
3-10: LGTM! Consistent migration documentation.The changelog entry consistently documents the dependency migration, matching the pattern used across other packages.
packages/cpf-val/pyproject.toml (1)
37-37: LGTM! Consistent dependency migration.The dependency update to
cpf-dvwith version constraint>=1.0.0,<2.0.0is consistent with other packages in this migration.packages/cnpj-val/src/cnpj_val/cnpj_validator.py (1)
1-1: LGTM! Import correctly updated for dependency migration.The import statement has been properly updated from
cnpj_cdtocnpj_dv. TheCnpjCheckDigitsclass interface remains unchanged, ensuring compatibility.packages/cpf-val/src/cpf_val/cpf_validator.py (1)
1-1: LGTM! Import correctly updated for dependency migration.The import statement has been properly updated from
cpf_cdtocpf_dv, maintaining the sameCpfCheckDigitsclass interface.packages/cpf-gen/README.md (2)
137-137: LGTM! Documentation correctly updated.The features list has been updated to reference
cpf-dvinstead ofcpf-cd.
225-225: LGTM! Dependencies section updated.The dependencies section correctly lists
cpf-dvas the check digit calculation dependency.packages/cpf-gen/pyproject.toml (1)
38-38: Package verified on PyPI with appropriate version constraints.The
cpf-dvpackage is published and available on PyPI (version 1.0.0, stable, not yanked). The version constraint>=1.0.0,<2.0.0correctly allows the current stable version while preventing breaking changes from future major versions. The dependency migration is sound.packages/cnpj-val/pyproject.toml (1)
37-37: The cnpj-dv package is published on PyPI and available. Version 1.0.0 is currently available, and the constraintcnpj-dv>=1.0.0,<2.0.0correctly allows this version with flexibility for future major releases. The dependency specification is sound.packages/cnpj-gen/src/cnpj_gen/cnpj_generator.py (1)
3-3: LGTM - Import migration is consistent.The import change from
cnpj_cdtocnpj_dvis consistent with the broader migration effort. TheCnpjCheckDigitsAPI usage remains unchanged, ensuring backward compatibility.packages/cpf-val/README.md (1)
92-92: LGTM - Documentation correctly updated.The README documentation has been properly updated to reflect the migration from
cpf-cdtocpf-dv, ensuring consistency with the actual dependency changes.Also applies to: 144-144
requirements.txt (1)
1-1: Verify package versions are published and compatible.Ensure the specified versions of
cnpj-dvandcpf-dvare available on PyPI and provide the same API as the previouscnpj-cdandcpf-cdpackages.Also applies to: 6-6
packages/cnpj-gen/pyproject.toml (1)
38-38: LGTM - Good use of version constraints.The dependency migration from
cnpj-cd>=1.0.1tocnpj-dv>=1.0.0,<2.0.0is well-structured. The addition of the upper bound<2.0.0follows semantic versioning best practices and helps prevent unexpected breaking changes from major version updates.packages/cnpj-gen/CHANGELOG.md (1)
3-30: LGTM - Changelog is thorough and consistent.The changelog clearly documents the migration, including dropped and added dependencies. The historical entries (1.0.1 and 1.0.0) have also been updated to reference
cnpj-dvfor consistency.packages/cnpj-val/CHANGELOG.md (1)
3-30: LGTM - Changelog comprehensively documents the migration.The changelog effectively documents the migration from
cnpj-cdtocnpj-dv, with clear sections for dropped and added dependencies. Historical entries are also updated for consistency.packages/cpf-gen/src/cpf_gen/cpf_generator.py (1)
3-3: Migration to cpf-dv is complete.All references to the old
cpf_cdpackage have been removed from the codebase. The newcpf-dvpackage is properly configured as a local monorepo package with correct version constraints (≥1.0.0, <2.0.0) in cpf-gen's dependencies.
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.