-
Notifications
You must be signed in to change notification settings - Fork 0
Deprecating cnpj-cd and cpf-cd packages
#43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughDeprecates two packages ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
packages/cnpj-cd/README.mdpackages/cnpj-cd/pyproject.tomlpackages/cnpj-cd/src/cnpj_cd/__init__.pypackages/cpf-cd/README.mdpackages/cpf-cd/pyproject.tomlpackages/cpf-cd/src/cpf_cd/__init__.py
🔇 Additional comments (6)
packages/cpf-cd/pyproject.toml (1)
20-20: LGTM! Appropriate classifier for deprecated package.The "7 - Inactive" development status correctly signals to PyPI users that this package is no longer maintained, aligning with the deprecation strategy.
packages/cnpj-cd/pyproject.toml (1)
20-20: LGTM! Appropriate classifier for deprecated package.The "7 - Inactive" development status correctly signals to PyPI users that this package is no longer maintained.
packages/cnpj-cd/src/cnpj_cd/__init__.py (2)
1-2: LGTM! Proper import for deprecation warning.The
warningsmodule import is correctly added to support the deprecation notice.
21-25: Deprecation warning implemented correctly.The runtime warning uses
DeprecationWarningwithstacklevel=2, which is the standard approach for library deprecations. Note thatDeprecationWarningis hidden by default in Python production environments (visible during testing), which is by design to avoid cluttering end-user logs. Since your README includes a prominent deprecation notice, users will be informed through documentation.If you want the warning to be visible in all contexts, consider using
FutureWarninginstead, which is shown by default.Would you like to verify that
DeprecationWarning(hidden by default) is the intended choice, or wouldFutureWarning(always visible) better serve your deprecation strategy?packages/cpf-cd/src/cpf_cd/__init__.py (2)
1-2: LGTM! Proper import for deprecation warning.The
warningsmodule import is correctly added to support the deprecation notice.
23-27: Deprecation warning implemented correctly.The runtime warning uses
DeprecationWarningwithstacklevel=2, following Python's standard library deprecation practices. This warning type is hidden by default in production (visible during development/testing), which prevents log pollution for end users while alerting developers during integration.Combined with the prominent README notice, this provides appropriate multi-layered deprecation communication.
If you prefer the warning to be always visible to all users, consider
FutureWarninginstead ofDeprecationWarning.
Summary by CodeRabbit
Documentation
Deprecation
✏️ Tip: You can customize this high-level summary in your review settings.