-
Notifications
You must be signed in to change notification settings - Fork 0
Update overall dependencies #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ddd33b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR updates development dependencies across the project to newer versions, affecting the root and multiple package-specific package.json files. A new changeset file marks several packages for patch version releases. Coverage metrics in lcov.info files are also updated. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
82-84: Dev‑tool bumps look reasonable; double‑check commitlint v20 compatibilityThe updated devDependencies are all tooling‑related and in‑scope for this PR. The only potentially breaking changes are the major upgrades to
@commitlint/cliand@commitlint/config-conventional(19→20); please ensure:
- your Node/CI versions satisfy their new engine requirements, and
- existing commitlint config still passes under v20.
Everything else (eslint, prettier, lint‑staged, typescript, etc.) are patch/minor bumps and should be low‑risk.
Also applies to: 87-88, 90-92
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (17)
.changeset/fine-carrots-open.md(1 hunks)package.json(1 hunks)packages/br-utils/package.json(1 hunks)packages/cnpj-fmt/package.json(1 hunks)packages/cnpj-fmt/tests/__coverage__/lcov.info(1 hunks)packages/cnpj-gen/package.json(1 hunks)packages/cnpj-gen/tests/__coverage__/lcov.info(2 hunks)packages/cnpj-utils/package.json(1 hunks)packages/cnpj-val/package.json(1 hunks)packages/cnpj-val/tests/__coverage__/lcov.info(3 hunks)packages/cpf-fmt/package.json(1 hunks)packages/cpf-fmt/tests/__coverage__/lcov.info(1 hunks)packages/cpf-gen/package.json(1 hunks)packages/cpf-gen/tests/__coverage__/lcov.info(2 hunks)packages/cpf-utils/package.json(1 hunks)packages/cpf-val/package.json(1 hunks)packages/cpf-val/tests/__coverage__/lcov.info(3 hunks)
🔇 Additional comments (9)
packages/cpf-fmt/tests/__coverage__/lcov.info (1)
67-67: LCOV artifact change looks consistent
LF:62matchesLH:62; this looks like a regenerated coverage artifact from the updated toolchain, nothing concerning here.packages/cpf-gen/tests/__coverage__/lcov.info (1)
67-67: Updated LF counts are internally consistentBoth updated
LFvalues (62 and 37) remain ≥ their respectiveLHvalues (44 and 37), so the regenerated coverage data is structurally valid.Also applies to: 111-111
packages/cnpj-val/tests/__coverage__/lcov.info (1)
67-67: Coverage LF reductions align with LH valuesAll three updated
LFvalues (62, 42, 12) are compatible with theirLHvalues (20, 37, 12). This looks like expected output from a newer coverage/tooling version.Also applies to: 116-116, 135-135
packages/cnpj-fmt/tests/__coverage__/lcov.info (1)
69-69: LCOV summary remains coherent after LF update
LF:64now matchesLH:64, so the updated summary still reflects 100% line coverage for this file under the new tooling.packages/cnpj-gen/tests/__coverage__/lcov.info (1)
69-69: Regenerated coverage data appears validThe new
LFcounts (64 and 43) are still ≥ theirLHcounterparts (46 and 42), so these LCOV updates look like normal fallout from dependency/tooling upgrades.Also applies to: 119-119
packages/cpf-val/tests/__coverage__/lcov.info (1)
67-67: Consistent LF adjustments across cpf‑val coverage recordsAll three updated
LFvalues (62, 37, 13) correctly bound their correspondingLHvalues (21, 33, 13); looks like expected regenerated coverage with the updated toolchain.Also applies to: 111-111, 131-131
.changeset/fine-carrots-open.md (1)
1-13: Changeset scope matches dependency‑only updatesTagging all affected packages with a patch bump for “Update overall dependencies” aligns with the dev‑tooling/coverage‑only nature of this PR.
packages/cnpj-gen/package.json (2)
54-74: Verify build pipeline compatibility after dependency updates.While dependency version bumps are routine maintenance, these toolchain and build tool updates (particularly the major version jump in @rollup/plugin-commonjs and minor updates to multiple Rollup plugins) should be validated to ensure the build pipeline continues to function correctly and produces valid CommonJS and ESM outputs.
Please confirm that:
- The build completes successfully with all updated dependencies
- Generated artifacts (
.cjs,.mjs,.d.ts) are valid and correctly formatted- No new peer dependency conflicts are introduced
- Test coverage remains intact post-update
57-57: @rollup/plugin-commonjs v29.0.0 upgrade is safe with default configuration.The major version bump to @rollup/plugin-commonjs 29.0.0 introduces a breaking change related to the
requireNodeBuiltinsoption, which controls how Node built-ins from wrapped CommonJS modules are handled. However, since the rollup configuration does not explicitly set this option, the default value (requireNodeBuiltins: false) is used, maintaining backward compatibility and hoisting Node built-ins as ESM imports as before. The upgrade should not require any code changes.
| "@babel/preset-env": "^7.28.5", | ||
| "@rollup/plugin-babel": "^6.1.0", | ||
| "@rollup/plugin-commonjs": "^29.0.0", | ||
| "@rollup/plugin-node-resolve": "^16.0.3", | ||
| "@rollup/plugin-terser": "~0.4.4", | ||
| "@rollup/plugin-typescript": "^12.1.4", | ||
| "@types/node": "^22.17.2", | ||
| "rollup": "^4.47.1", | ||
| "@rollup/plugin-typescript": "^12.3.0", | ||
| "@types/node": "^22.19.1", | ||
| "rollup": "^4.53.3", | ||
| "rollup-plugin-delete": "^3.0.1", | ||
| "rollup-plugin-dts": "^6.2.3", | ||
| "rollup-plugin-dts": "^6.3.0", | ||
| "rollup-plugin-esbuild": "^6.2.1", | ||
| "typescript": "^5.9.2" | ||
| "typescript": "^5.9.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
Rollup 4.53.3 @rollup/plugin-babel 6.1.0 @rollup/plugin-commonjs 29.0.0 @rollup/plugin-node-resolve 16.0.3 @rollup/plugin-typescript 12.3.0 compatibility
💡 Result:
Short answer: Yes — Rollup 4.53.3 is compatible with those plugin versions, but check Node and peer-deps and a couple of usage details.
Key points
- Rollup 4.53.3 (released Nov 19, 2025) — update to Rollup 4 requires Node 18+ and “update all your Rollup plugins to their latest versions.” Test your config after upgrading. [1][2]
- @rollup/plugin-babel 6.1.0 — current plugin release; works with Rollup 4 (ensure babelHelpers config and place commonjs before babel if using both). [3]
- @rollup/plugin-commonjs 29.0.0 — current release; compatible with Rollup 4. Put commonjs before babel in plugins array when needed. [4]
- @rollup/plugin-node-resolve 16.0.3 — current release; compatible with Rollup 4. [5]
- @rollup/plugin-typescript 12.3.0 — current release; compatible with Rollup 4 but requires installing TypeScript and tslib as peer deps (and node LTS). Test TypeScript-specific config after upgrade. [6]
Recommendations
- Use Node 18+ (Rollup 4 requirement). [2]
- Install plugin peer deps (typescript, tslib, @babel/core, etc.) and run your full build/test suite after upgrading. [3][6]
- If you hit type errors from plugin typing changes, update TypeScript and plugin types and check the Rollup migration guide for breaking changes. [2]
Sources
[1] Rollup release v4.53.3 (GitHub).
[2] Rollup migration / Rollup 4 prerequisites (rollupjs.org).
[3] @rollup/plugin-babel (jsdocs / npm).
[4] @rollup/plugin-commonjs (jsdocs).
[5] @rollup/plugin-node-resolve (jsdocs).
[6] @rollup/plugin-typescript (npm / Snyk).
Verify Node version requirement and plugin peer dependencies after Rollup ecosystem upgrade.
The devDependency updates are compatible: Rollup 4.53.3 works with @rollup/plugin-babel 6.1.0, @rollup/plugin-commonjs 29.0.0, @rollup/plugin-node-resolve 16.0.3, and @rollup/plugin-typescript 12.3.0. However, Rollup 4 requires Node 18+, and the plugins require peer dependencies (typescript, tslib, @babel/core) to be installed. Additionally, ensure @rollup/plugin-commonjs is placed before @rollup/plugin-babel in the plugins array if both are used. Run the full build and test suite after upgrading to verify the configuration works.
🤖 Prompt for AI Agents
In packages/br-utils/package.json around lines 68 to 79, after upgrading Rollup
and its plugins ensure the package declares the Node engine requirement (set
engines.node >=18) and that required peer dependencies are present in
devDependencies (install/types as needed: typescript is present but add/verify
tslib and @babel/core), update package.json devDependencies accordingly, adjust
your rollup config to place @rollup/plugin-commonjs before @rollup/plugin-babel
in the plugins array, and then run the full build and test suite to confirm the
configuration works.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.