Skill (Senior Review): the senior review command and guidelines for architectural feedback#4
Skill (Senior Review): the senior review command and guidelines for architectural feedback#4BenDavies1218 wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Claude Code slash-command prompt (/senior-review) aimed at producing senior-level architectural/design feedback on code changes, complementing existing review-oriented tooling in this config repo.
Changes:
- Introduces a structured “senior design review” workflow (context gathering, full-file reading, deep architectural analysis).
- Defines a fixed output template for consistent senior-review writeups and mentoring-style feedback guidelines.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
simon-tanna
left a comment
There was a problem hiding this comment.
This is a good addition to our config! I would however recommend porting this to a skill as slash commands have been deprecated by anthropic in favour of skills. anthropics/claude-plugins-official#537
suggestion: Add the plugin-dev plugin from anthropics marketplace and run the /skill-creator giving it this command as context.
|
What Simon said. Also, we already have a code-review agent - https://github.com/Labrys-Group/Claude-Config/blob/main/agents/code-reviewer.md. Can this be merged with that, or is it sufficiently distinct to warrant a separate skill? |
|
@sjustintaylor I think it'd be nice to have this essentially automate what the agent does. /code-review is a lot quicker to invoke than |
That's an idea. I use the Codex /review command like that. |
Credit to @geedawi
I have been using this skill for a while and have found it nice.
It looks at the changes both staged and committed against the base branch.
It then does a software design and architecture focused review of the code.
It works very fast within 30-60 seconds and picks up a lot of basic logically errors and provides domain and architecture design suggestions.
Of course read recommendations with a gain of salt