fix "Invalid array length" #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix `Cannot read properties of undefined (reading 'startsWith')`
Contributor
|
Hello @saerdnaer, Thank you for your contribution! Could you please provide more context around the changes you’ve made, particularly regarding the "Invalid array length" fix? It would be helpful to understand the specific scenarios where you encountered this issue and the cases your fix is addressing. Additionally, if possible, could you also elaborate on the other changes you’ve implemented? This information will greatly assist in reviewing and understanding the improvements. Thanks again! |
adussarps
reviewed
Aug 19, 2024
| for (let i = 0; i < originalItems.length; i++) { | ||
| const originalItem: Item = originalItems[i]!; | ||
| const emptyItemsToAdd = originalItem[fieldKey].length - field.update?.length - field.delete?.length; | ||
| const emptyItemsToAdd = field.update?.length - originalItem[fieldKey].length - field.delete?.length; |
Contributor
There was a problem hiding this comment.
emptyItemsToAdd is counting the number of "untouched sub items" during a create / update / delete operation on a specific field here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.