Various fixes/enhancements to FollowReference/UAV#206
Open
krisgry wants to merge 4 commits intoLSTS:masterfrom
Open
Various fixes/enhancements to FollowReference/UAV#206krisgry wants to merge 4 commits intoLSTS:masterfrom
krisgry wants to merge 4 commits intoLSTS:masterfrom
Conversation
If after, it is not dispatched
Is needed upon consume FollowReference
EstimatedState if not received Reference This fixes a bug where the reference would jump to the current position at the start of a FollowReference Maneuver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9d0a5e3 fixes what seems to be a typo (&& instead of ||)
f41de2d reorders signalError and a dispatch, as the message was never dispatched
The two other commits are more of a design question, I guess, but the current master code is ambigous:
There are two ways to fix this:
Tested in flight