-
Notifications
You must be signed in to change notification settings - Fork 3
feat: retrieve struct validation #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Will-Mann-16
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things to change that I can see - especially about expected behaviours
|
Can we also add some form of documentation showcasing this behaviour? |
|
I did add a new example what else do you want me to add to showcase the feature? |
On the readme or a new file in the docs showcasing this feature, this seems like one of our major selling points (maybe add to the bullet points at the top of the readme?) |
|
Think I'm not following this PRs purpose, is it just |
|
Its the whole |
|
Also something I thought of, can we get an integration test demonstrating this behaviour |
|
I have now updated the |
|
I will merge |
|
@Will-Mann-16 I think this is now ready for a re-review! |
|
@Will-Mann-16 |
This PR adds support for struct validation, It pulls the information for the Go Validator V10 tags and converts into OpenAPI schemas.
For reference, natively gin uses the
bindingtag name as opposed tovalidate(which is the go validator default)