Skip to content

feat(middleware): added unstable support #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Will-Mann-16 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(middleware): added unstable support #53

Will-Mann-16 wants to merge 5 commits into from

Conversation

@Will-Mann-16
Copy link
Contributor

@Will-Mann-16 Will-Mann-16 commented Jan 5, 2024

This is UNSTABLE as not entirely working but I want to get the baseline out there

  • Added middleware tests
  • Added middleware support for tracethrough handlers using reflect to find them inside gin.Engine.
  • Doesn't currently work with higher-order functions, which is a common pattern (works inside Jetbrains debugging environment but not runtime???)

TommoLeedsy
TommoLeedsy requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@TommoLeedsy TommoLeedsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Will-Mann-16 Looks good, you just need to fix the lint errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TommoLeedsy TommoLeedsy TommoLeedsy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Will-Mann-16 @TommoLeedsy