Adding APIv4 Support and a few other features

[attzonko]

This is our working version of the BOT which integrates a few of the outstanding pull requests as well as adds support for APIv4. Many of the changes including the APIv4 support were previously contributed by @seLain back in Sep'17, I just grabbed them from his repository and got them to work together with a few minor tweaks. Below is a high level summary of the changes.

• Adding APIv4 Support (source branch) Mattermost moving to API version 4 #35
• Enabling local settings enable local settings #47
• Allow posts from multiple teams allow posts to many teams #46 Team support #45 Team support ? #39
• Added missing default plugins PyPI out of sync with github? #54
• Added ignore 'ignore strings' anywhere in a message ignore messages with ignore strings anywhere in message, not just the beginning #37
• A few other minor cosmetic changes

[jasonblais]

@gotlium let us know if you have time to review this PR. Thanks! :)

[jasonblais]

@gotlium @deniskabalkin Would you have thoughts on the best way to transfer ownership of https://pypi.python.org/pypi/mattermost_bot?

@attzonko is open to assuming ownership of the repo and/or forking it for now.

[epatpol]

I was actually looking into making the bot work with apiv4, but it seems there's already a PR opened for it (awesome!). So for that I hope @gotlium gives a pong back soon :)

[Sebastien-Meiffren]

Hi,
I've been trying to use your new version of the bot, but I keep having a team issue

Traceback (most recent call last):
  File "C:/Users/chuiv/PycharmProjects/bot_mattermost/run.py", line 5, in <module>
    Bot().run()
  File "C:\Users\chuiv\PycharmProjects\bot_mattermost\mattermost_bot\bot.py", line 29, in __init__
    settings.SSL_VERIFY)
  File "C:\Users\chuiv\PycharmProjects\bot_mattermost\mattermost_bot\mattermost_v4.py", line 110, in __init__
    self.login(team, email, password)
  File "C:\Users\chuiv\PycharmProjects\bot_mattermost\mattermost_bot\mattermost.py", line 184, in login
    self.user = self.api.login(team, email, password)
  File "C:\Users\chuiv\PycharmProjects\bot_mattermost\mattermost_bot\mattermost_v4.py", line 25, in login
    self.load_initial_data()
  File "C:\Users\chuiv\PycharmProjects\bot_mattermost\mattermost_bot\mattermost_v4.py", line 34, in load_initial_data
    self.default_team_id = self.teams[0]['id']
IndexError: list index out of range

If I print self.teams = self.get('/teams'), I get an empty array []

If I connect to the webclient like a normal person / user, everything works fine

[attzonko]

@Sebastien-Meiffren I went ahead and opened an issue for you in my fork, for now it would be easier to resolve this there and push the change/fix to this pull request. Here is the link to the issue.

[epatpol]

Sorry to hijack this PR but as a python beginner what's the best way to use your fork meanwhile? I used pip to get the latest version from LPgenerator but I would like to test out these changes at the moment.

[seLain]

I would do it this way without removing installed mattermost_bot (from PyPI) :

1. create a virtual environment mmpy_bot_test
   python -m venv mmpy_bot_test
2. activate the virtual environment
   mmpy_bot_test\Scripts\activate
3. install attzonko's fork:master
   pip install git+https://github.com/attzonko/mattermost_bot.git
4. then you can test your bot under this virtual environment

[timball]

MM api docs claim that the v3 api is deprecated as of 2018-01-16.

How far away is this code from being able to be merged?

--timball

[attzonko]

@timball Not sure the original author is ever planning to merge this in. Feel free to use my fork of this project. I plan on making a new pypi package shortly.

[timball]

Oh cool. can you update your docs? i tried to follow the example in the readme and it blows up.

…

--timball

On Tue, Feb 27, 2018 at 1:34 PM, Alex Tzonkov ***@***.***> wrote: @timball <https://github.com/timball> Not sure the original author is ever planning to merge this in. Feel free to use my fork of this project. I plan on making a new pypi package shortly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACY8EjTCtDmiih0oJfptZV57oWQQ1nQks5tZEpBgaJpZM4RVLQo> .

-- GPG key available on sks-keyservers.net pub rsa2048/D0A8B0F1638B16EF 2018-01-03 Timothy Lu Hu Ball < timball@gmail.com> Primary key fingerprint: 1453 FD65 1D18 A992 621E E4BE D0A8 B0F1 638B 16EF

[epatpol]

Before you could get around without using MATTERMOST_BOT_SETTINGS_MODULE but now you have to? I see that you changed it from os.get to os.environ, any reasons for that?

[epatpol]

NVM I see that you updated the readme on how to use it thank you :)

[timball]

actually i figured what i did wrong. typo put `http` instead of `https` and it gave a non-sensical error. Fixed the typo and i'm off to the races. thanks!

…

--timball

On Thu, Mar 1, 2018 at 5:14 PM, Patrick-Jeffrey Pollo Guilbert < ***@***.***> wrote: NVM I see that you updated the readme on how to use it thank you :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACY8J1uBUCKDS9kMv9b_MF5pk1qt_GYks5taHLHgaJpZM4RVLQo> .

-- GPG key available on sks-keyservers.net pub rsa2048/D0A8B0F1638B16EF 2018-01-03 Timothy Lu Hu Ball < timball@gmail.com> Primary key fingerprint: 1453 FD65 1D18 A992 621E E4BE D0A8 B0F1 638B 16EF

[scottleedavis]

@attzonko I am interested in contributing! I have a vested interest in seeing this apiV4 support thru and love python too! :)

[attzonko]

@scottleedavis Hey we ended up creating a new repo from this instead of a fork to change the name and be able to release pypi packages. take a look at https://github.com/attzonko/mmpy_bot

Would love to have you contribute!