This repository was archived by the owner on Jul 12, 2020. It is now read-only.
WIP: Implement HttpService:RequestAsync #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I've talked about this via other channels, but LuaSocket's HTTP won't be enough for this feature. Roblox code can assume that other threads will run while HTTP requests are in-flight, but LuaSocket is synchronous as far as I know. I prototyped a new, async HTTP interface for Lua over here: https://github.com/LPGhatguy/lua-async-http |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101.
This PR implements a real version of
HttpService:RequestAsyncusing LuaSocket'ssocket.httpandltn12modules.HttpServicecan also be constructed using a fake HTTP implementation, which is useful for testingHttpServiceitself, but may also be useful for consumers of Lemur. Before merging this, perhaps I should also add a configuration option to habitats to disable real HTTP requests or make them cause errors.Merge checklist: