Open
Conversation
Collaborator
jurjen93
commented
Feb 20, 2026
jurjen93
commented
- Bug fix for DD validation
- Make DD validation less strict
- Align DD validation with DI validation (no different modes)
tikk3r
reviewed
Feb 24, 2026
Member
tikk3r
left a comment
tikk3r
left a comment
There was a problem hiding this comment.
Nice simplification. Indeed since the DI and DD cases differ by 0.05 in amplitude score I can believe it makes sense to just remove that alltogether.
Comment on lines
+81
to
+83
| if args.error_on_bad_solutions and len(validation_csv[(validation_csv['accept_image']) & (~validation_csv['accept_solutions'])])>0: | ||
| exit("ERROR: Following directions should be inspected: \n" | ||
| f"{'\n'.join(list(validation_csv[(validation_csv['accept_image']) & ~(validation_csv['accept_solutions'])].source_id))}") |
Member
There was a problem hiding this comment.
The level of nested statements is maybe a bit hard to read. I would recommend extracting the condition (validation_csv['accept_image']) & (~validation_csv['accept_solutions']) into a variable, for example, as it is used twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.