Open
Conversation
This MR fixes: - An issue that comes up when running get_phasediff.cwl and concat_csv.cwl with Toil-CWL-runner without singularity container, where double quotation marks are not interpreted the same as single quotation marks. - Make the phasediff_ms writable, as it updates the input MS when converting the dataset from linear to circular polarisation, which makes it impossible to restart a failed job. - Add back the pre-averaging before phasediff selection to speedup processing.
This PR adds resource requirements based on running the subtraction on a Lockman pointing on cosma. **DIS2 h5parm merging** ``` 87.61user 63.33system 2:34.87elapsed 97%CPU (0avgtext+0avgdata 86228096maxresident)k │ 8226448inputs+28627944outputs (1725major+1981817minor)pagefaults 0swaps ``` **Subtracting one chunk** Looking at the output of `time` it seems the prediction only uses ~45 GB ``` 3589.76user 403.85system 12:43.18elapsed 523%CPU (0avgtext+0avgdata 45454272maxresident)k │ - class: ResourceRequirement 2143544inputs+100504136outputs (2932major+52721951minor)pagefaults 0swaps ``` the the OoM killer kept kicking in and DDFacet itself reported ~125GB so perhaps there's a small spike somewhere or something like that. That is where the 128 GB ramMin comes from.
Collaborator
Author
|
The diff shows again changes from other MR that were added after rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR:
split_parset.cwltosplit_direction_single_ms.cwl, since that fits better its purpose as it also performs now concatenation after splitting a subband.