Make dataset writable and fix quotation input parameters#95
Merged
Make dataset writable and fix quotation input parameters#95
Conversation
tikk3r
previously approved these changes
Feb 17, 2026
tikk3r
reviewed
Feb 18, 2026
Member
tikk3r
left a comment
tikk3r
left a comment
There was a problem hiding this comment.
The fixes look good. Just have some clarifying questions.
Why is the pre-averaging step added over just keeping the averaging settings in the call to facetselfcal? Is this to save some I/O by having the initial averaging call need only read access to the input such that the writable copy for facetselfcal is quicker?
tikk3r
approved these changes
Feb 18, 2026
Member
tikk3r
left a comment
tikk3r
left a comment
There was a problem hiding this comment.
The parameter changes sound sensible, so approved in my book.
jurjen93
added a commit
that referenced
this pull request
Feb 24, 2026
This MR fixes: - An issue that comes up when running get_phasediff.cwl and concat_csv.cwl with Toil-CWL-runner without singularity container, where double quotation marks are not interpreted the same as single quotation marks. - Make the phasediff_ms writable, as it updates the input MS when converting the dataset from linear to circular polarisation, which makes it impossible to restart a failed job. - Add back the pre-averaging before phasediff selection to speedup processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR fixes: