Skip to content

Add Sage and Oscar code snippets for Galois groups#6881

Merged
roed314 merged 21 commits intoLMFDB:mainfrom
rvisser7:galois
Feb 22, 2026
Merged

Add Sage and Oscar code snippets for Galois groups#6881
roed314 merged 21 commits intoLMFDB:mainfrom
rvisser7:galois

Conversation

@rvisser7
Copy link
Contributor

@rvisser7 rvisser7 commented Feb 15, 2026

This PR adds more code snippets in Sage and Oscar for Galois groups. Also updated the Magma/Sage/Oscar sidebar download links to use all the code snippets (thereby updating the snippet tests to check all the generated code snippets).

Comments/feedback very welcome! :)

E.g. Galois group 4T2
https://beta.lmfdb.org/GaloisGroup/4T2
http://localhost:37777/GaloisGroup/4T2

E.g. Galois group 11T5
https://beta.lmfdb.org/GaloisGroup/11T5
http://localhost:37777/GaloisGroup/11T5

@rvisser7 rvisser7 marked this pull request as draft February 16, 2026 18:38
@rvisser7 rvisser7 marked this pull request as ready for review February 20, 2026 17:05
@roed314
Copy link
Member

roed314 commented Feb 20, 2026

There are merge conflicts now. Maybe it's better to not show the specific id in the deprecation warning, but use ... instead.

@rvisser7
Copy link
Contributor Author

Thanks, I've resolved the merge conflicts. I've also just submitted the PR #6887 which now finally updates the Sage command for Galois group :).

I agree we could have a look at modifying the code that generates the code snippet logs to avoid logging the specific ids (which changes every time we regenerate the snippet logs). Merging PR #6887 should resolve this in any case.

That said, perhaps it's not the worst idea to have these id annoyances, as that way it will hopefully encourage people to actually fix the underlying code snippets and eliminate the deprecation warnings altogether. 🙂

@roed314
Copy link
Member

roed314 commented Feb 22, 2026

Oops, I think merging #6887 means this has merge conflicts again....

@rvisser7
Copy link
Contributor Author

rvisser7 commented Feb 22, 2026

No worries, conflicts have now been resolved (accepted all incoming changes)! Fortunately, now that #6887 has been merged, should this hopefully be the last time we'll have to resolve any DeprecationWarning id conflicts for these Sage snippet log files (at least for the Galois group snippet). 🙂

@roed314 roed314 merged commit 60cf8f2 into LMFDB:main Feb 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants