Skip to content

Catch errors in completeness framework#6879

Merged
AndrewVSutherland merged 2 commits intoLMFDB:mainfrom
roed314:completeness_fix
Feb 22, 2026
Merged

Catch errors in completeness framework#6879
AndrewVSutherland merged 2 commits intoLMFDB:mainfrom
roed314:completeness_fix

Conversation

@roed314
Copy link
Member

@roed314 roed314 commented Feb 14, 2026

With this PR, errors in the completeness framework print a warning message and log an error to the flasklog, instead of causing a server error. We can find and fix the underlying problems by examining the flasklog.

Compare:

@roed314
Copy link
Member Author

roed314 commented Feb 20, 2026

@AndrewVSutherland we can use app.logger to print to the flasklog. I'm going to make another issue for cleaning up the loggers.

@roed314
Copy link
Member Author

roed314 commented Feb 22, 2026

@AndrewVSutherland if you can review this and #6870 I can make a PR to alpha, dev and web.

@AndrewVSutherland
Copy link
Member

This works, but I note that there are no timestamps in the flasklog. I don't think it's worth delaying this to fix/change that so I am merging.

@AndrewVSutherland AndrewVSutherland merged commit af17e64 into LMFDB:main Feb 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants