ECQ: show base-changed curves in database on curve home pages#6854
Closed
JohnCremona wants to merge 2 commits intoLMFDB:mainfrom
Closed
ECQ: show base-changed curves in database on curve home pages#6854JohnCremona wants to merge 2 commits intoLMFDB:mainfrom
JohnCremona wants to merge 2 commits intoLMFDB:mainfrom
Conversation
Member
|
FYI, tests failed because the Clabel attribute was not set for a random curve (this can happen, e,g, for curves of conductor > 500000), but I'm confused as to how your change would have cause this (or if it didn't why we haven't seen this before). |
Member
|
Rerunning the test fixed the problem (presumably a different random curve). |
Member
Author
|
Option (1) which lists all the curve in the Related Objects section is implemented by line 567 in the patch so that line can be deleted once option (2), implemented in line 568, works. What is needed there is a URL which shows the result of an ECNF search for curves whose label is in the list bclabels. The code now on line 567 does not achieve this. |
Member
|
Should we close this in view of #6878? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR towards satisfying the feature request #6833 . It implements both options (1) and (2) defined there, though the implementation of (2) does not work properly. My intention is that someone fixes (2) and then we remove option (1).