feat: add new pkphelperv2 features to a new endpoint on the relay#41
feat: add new pkphelperv2 features to a new endpoint on the relay#41
Conversation
| case "manzano": | ||
| return getContractFromWorker('manzano', 'PKPHelperV2'); | ||
| case "habanero": |
There was a problem hiding this comment.
I think much of the network resolving implementations are already implemented in the PR here: #37
There was a problem hiding this comment.
Yeah, that's where the getContractFromWorker function comes from. This implementation is a mirror of the exiting getPKPHelperContract function, which should include the changes in #37 . Am I missing something?
There was a problem hiding this comment.
No this does look to match, just wanted to call it out incase it wasnt known
lit.ts
Outdated
| burnPkp: boolean; | ||
| }): Promise<ethers.Transaction> { | ||
| console.log( | ||
| "In mintPKPV2", |
There was a problem hiding this comment.
Yeah, that's wrong. Should be V3.
|
@jtary what is the release plan for this feature? is there a corresponding contract implementation that can be referenced? |
Contract is here: https://github.com/LIT-Protocol/lit-assets/blob/develop/blockchain/contracts/contracts/lit-node/PKPHelperV2.sol Don't think there is a release plan yet. @glitch003 any plans for this? |
|
|
||
| // first get mint cost | ||
| const mintCost = await pkpNft.mintCost(); | ||
| const tx = await pkpHelper.mintNextAndAddAuthMethods( |
There was a problem hiding this comment.
interesting that this implementation is not using the queuing system which will guarantee ordering nonce any reason for this not to be used?
Add Endpoint for new PKPHelperV2
Description
Adds a new endpoint to expose the create PKP function of the PKPHelperV2 contract.
Endpoint
The endpoint is available at
POST /mint-next-and-add-auth-methods-v2and accepts a body with the following parameters: