Open
Conversation
- 사용자 전체 조회 InternalApi 요청 컨트롤러 추가했습니다
- 사용자 전체 조회 Repository 메소드 작성했습니다
- 사용자 전체 조회 서비스 메소드 작성했습니다
| return UserMapper.toGetMyPageResponse(user); | ||
| } | ||
|
|
||
| @Transactional |
Member
There was a problem hiding this comment.
readOnly를 사용하여 조회용 트랜잭션임을 명시해 주시는 것도 좋을 것 같습니다!
| return ResponseEntity.ok(response); | ||
| } | ||
|
|
||
| @GetMapping |
Member
There was a problem hiding this comment.
관리자만 요청이 가능하게끔 구성하셔도 좋을 것 같습니다!
Member
There was a problem hiding this comment.
create시 uri 반환도 함께 하면 좋을 것 같아요!
chokyuseong00
approved these changes
Apr 29, 2025
-조회용 트랜잭션 명시해주는 readOnly 추가했습니다
sohyun119
reviewed
Apr 29, 2025
sohyun119
approved these changes
Apr 29, 2025
Member
sohyun119
left a comment
sohyun119
left a comment
There was a problem hiding this comment.
고생하셨습니다! 레디스 마무리하고 추가 기능 구현까지..엄지 다섯개 보내드립니다👍👍👍👍👍
- 관리자만 회원전체 조회 할 수 있도록 했습니다 - 체험단 생성 시 회원 정보를 미리 캐싱할 수 있도록 컨트롤러 메서드명을 명시적으로 변경
- 사용자 전체 조회 시 페이징 처리 추가했습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 변경 타입
✅ 체크리스트
🚀 PR 내용
한 줄 요약
*사용자 전체 조회 api 작성했습니다
세부 내용