Skip to content

Conversation

@SteSeg
Copy link
Contributor

@SteSeg SteSeg commented Jul 31, 2025

Here a newer version of materials for the neutronics modeling of libra. It centralizes all the openmc.Materials in the toolbox so it is not necessary to rewrite all the materials for every new experimental campaign repository.

for a new model it works like this:

from libra_toolbox.neutronics import materials

Cllif = neutronics.materials.Cllif

mymaterials = openmc.Materials([Cllif])

model = openmc.Model(materials=mymaterials)

The vault model in toolbox has been adapted.

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 99.54545% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.82%. Comparing base (f460865) to head (8de9cee).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
libra_toolbox/neutronics/vault.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   86.48%   86.82%   +0.33%     
==========================================
  Files          18       19       +1     
  Lines        1480     1503      +23     
==========================================
+ Hits         1280     1305      +25     
+ Misses        200      198       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks @SteSeg for this, very much needed! A few comments and we can merge this

libraries=["ENDFB-8.0-NNDC"],
set_OPENMC_CROSS_SECTIONS=True,
particles=["neutron"],
destination=cross_sections_destination,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this cause I think we may need it for the automation in the BABY run repos

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteSeg can you revert this change then I can merge this

SteSeg and others added 3 commits August 1, 2025 09:38
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
@RemDelaporteMathurin RemDelaporteMathurin merged commit ce2e9f5 into LIBRA-project:main Aug 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants