Deduplicate file arguments in format and fixup commands#262
Open
JosephDenman wants to merge 1 commit intomainfrom
Open
Deduplicate file arguments in format and fixup commands#262JosephDenman wants to merge 1 commit intomainfrom
JosephDenman wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: JosephDenman <joseph.denman@iohk.io>
JosephDenman
added
release: 0.31
Plugin Test Summary 1 files 3 suites 1s ⏱️ Results for commit 19f7ed0. |
Compactc E2E Tests Results - linux-release-x86_640 tests 0 ✅ 0s ⏱️ Results for commit 19f7ed0. |
Compactc E2E Tests Results - macos-release-aarch64 1 files 48 suites 2m 9s ⏱️ Results for commit 19f7ed0. |
Compactc E2E Tests Results - linux-release-aarch64 1 files 48 suites 3m 14s ⏱️ Results for commit 19f7ed0. |
Compactc E2E Test Summary2 825 tests 2 825 ✅ 5m 51s ⏱️ Results for commit 19f7ed0. ♻️ This comment has been updated with latest results. |
Compactc E2E Tests Results - macos-release-x86_64 1 files 48 suites 6m 47s ⏱️ Results for commit 19f7ed0. |
kmillikin
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #260 was flaking on
macos-latest—test_sc34passes the same file twice tocompact format --verbose, which spawns two concurrent tasks viaJoinSet. This PR deduplicates file paths before spawning async formatting/fixup tasks, fixing a race condition where two tasks would simultaneously invoke the external binary on the same file.