Conversation
We will subsequently rename and update the document to refer to CoIP, so it's easier to track changes to it. Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
Plugin Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 27d2a14. ♻️ This comment has been updated with latest results. |
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
kmillikin
force-pushed
the
kmillikin/coip
branch
from
3257a6d to
49ff965
Compare
Compactc E2E Tests Results2 706 tests 2 706 ✅ 5m 30s ⏱️ Results for commit 27d2a14. ♻️ This comment has been updated with latest results. |
E2E test resultsbuild: Run #70
🎉 All tests passed! |
Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 Flaky Rate
No current tests have flaky rates to display ✨ Github Test Reporter by CTRF 💚 |
|
General discussion can go in issue #26. |
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
E2E test resultsbuild: Run #72
🎉 All tests passed! |
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
E2E test resultsbuild: Run #137
🎉 All tests passed! |
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
E2E test resultsbuild: Run #138
🎉 All tests passed! |
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
E2E test resultsbuild: Run #139
🎉 All tests passed! |
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
kmillikin
force-pushed
the
kmillikin/coip
branch
from
6d8e29e to
0686815
Compare
E2E test resultsbuild: Run #142
🎉 All tests passed! |
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
E2E test resultsbuild: Run #143
🎉 All tests passed! |
E2E test resultsbuild: Run #179
🎉 All tests passed! |
|
Heads up Kevin, the changes in this PR are now also in #48. You need to sign one of your commits before this can be merged. Otherwise, would have merged it before adding the changes in my unrelated PR. |
|
This is not read to merge, it is still being worked on and it has no feedback from reviewers. I will change the status to draft to make that clear. |
This reverts commit 8ee9649. It will be submitted as a separate PR.
E2E test resultsbuild: Run #208
🎉 All tests passed! |
coips/coip-0001.md
Outdated
| This is a document that follows the template structure below. | ||
| The CoIP document is added to the `coips` subdirectory with the name `coip-XXXX.md` (those are literal `X`s). | ||
| The status of the CoIP is set to **Draft** and a pull request (PR) is made to add the draft document. | ||
| 1. **TSC approval of the draft:** The TSC approves merging the draft CoIP PR. |
There was a problem hiding this comment.
| 1. **TSC approval of the draft:** The TSC approves merging the draft CoIP PR. | |
| 2. **TSC approval of the draft:** The TSC approves merging the draft CoIP PR. |
There was a problem hiding this comment.
So by the end of step 2, we expect the PR to be merged and the status of the CoIP is approved?
There was a problem hiding this comment.
It's unclear from what follows that who is responsible to change the status of the CoIP as it evolves, i.e., draft --> submitted --> accepted/rejected --> implemented --> released. It is also unclear if we require a separate PR for each of these or if accepted/rejected --> implemented happens with the implementation PR and implemented --> released with the cut PR.
There was a problem hiding this comment.
-
GitHub's markdown renderer (as well as Slack, Stack Overflow, etc. and probably most other ones?) will number lists for you if they all start with a number, and so the numbers don't matter, they can even be out of order. (The implementation is to produce an
<ol>for the list with a<li>for each item and then HTML numbers them automatically. The numbers never appear after processing the markdown.) I like to use1.for all of them to make it easier to insert, remove, and potentially reorder items. -
This is step 3. By the end of step 3 the CoIP is merged to the repository. The status is "draft". This is so it can be worked on directly with PRs from multiple authors and history tracked in the repository rather than on a single long-running PR. I've seen proposals take six months or a year to get into a form where they can be accepted, and PRs to have hundreds of comments and get very difficult to follow. People also want to see WIP directly in the repository in the numbered file rather than having to search for the PR that has the WIP.
-
I did try to be very explicit in each step about what action was performed and who was performing it. I will ensure it's clear. TSC themselves or some maintainer will update CoIP statuses, authors don't need to send us PRs to do that for us.
coips/coip-0001.md
Outdated
| Note that this is **not** the same as acceptance of the CoIP. | ||
| The TSC will vote to merge the draft CoIP PR at their next regularly scheduled meeting. | ||
| They will ensure that the document is correctly formatted, that is it clear and understandable, and that it is well motivated. | ||
| The TSC will be generally lenient at this stage with the understanding that problems can be addressed before the CoIP is submitted. |
There was a problem hiding this comment.
| The TSC will be generally lenient at this stage with the understanding that problems can be addressed before the CoIP is submitted. | |
| The TSC will be generally lenient at this stage with the understanding that problems can't be addressed before the CoIP is submitted. |
There was a problem hiding this comment.
I will be more clear about the various kinds of submission. Problems can be addressed before final submission for yes/no vote, they do not need to be in the initial draft to get a number assigned.
| - Teams responsible for development | ||
| - Testing and audit milestones | ||
|
|
||
| ### CoIP Template |
There was a problem hiding this comment.
It might be more straightforward to have the template as a separate file under coips/coip-template.md.
There was a problem hiding this comment.
Yes, that is the remaining task. It doesn't belong here.
Co-authored-by: Parisa Ataei <paris.ataei@gmail.com> Signed-off-by: Kevin Millikin <kmillikin@gmail.com>
Signed-off-by: Kevin Millikin <kevin.millikin@shielded.io>
|
@kmillikin wondering what is the status here? as we are thinking to create a CoIP. |
5 participants
The CoIP process is started as a fork of the MIP (Midnight Improvement Proposal) process.