Skip to content

Add Ed448 (Goldilocks) curve support #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sridhar-panigrahi wants to merge 4 commits into
base: m
Choose a base branch
from
Open

Add Ed448 (Goldilocks) curve support #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc548f2
Add curve448 (Goldilocks) curve support
sridhar-panigrahi Mar 23, 2026
e963cf0
Fix formatting and update wasm/nostd lockfile
sridhar-panigrahi Mar 23, 2026
0081221
Rework curve448 into Ed448 per reviewer feedback
sridhar-panigrahi Apr 10, 2026
882b678
Address PR #61 reviewer feedback on ed448.rs
sridhar-panigrahi Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 129 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,7 @@ rand_dev = "0.1"
package = "curve25519-dalek"
version = "4"
default-features = false

[workspace.dependencies.ed448-goldilocks-plus]
version = "0.16"
default-features = false
16 changes: 9 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,19 +69,21 @@ multiplying `NonZero<Point<E>>` at `NonZero<Scalar<E>>` returns `NonZero<Point<E

Crate provides support for following elliptic curves out of box:

| Curve | Feature | Backend |
|--------------|--------------------|-------------------|
| secp256k1 | `curve-secp256k1` | [RustCrypto/k256] |
| secp256r1 | `curve-secp256r1` | [RustCrypto/p256] |
| secp384r1 | `curve-secp384r1` | [RustCrypto/p384] |
| stark-curve | `curve-stark` | [Dfns/stark] |
| Ed25519 | `curve-ed25519` | [curve25519-dalek]|
| Curve | Feature | Backend |
|--------------|--------------------|--------------------------|
| secp256k1 | `curve-secp256k1` | [RustCrypto/k256] |
| secp256r1 | `curve-secp256r1` | [RustCrypto/p256] |
| secp384r1 | `curve-secp384r1` | [RustCrypto/p384] |
| stark-curve | `curve-stark` | [Dfns/stark] |
| Ed25519 | `curve-ed25519` | [curve25519-dalek] |
| Ed448 | `curve-ed448` | [ed448-goldilocks-plus] |

[RustCrypto/k256]: https://github.com/RustCrypto/elliptic-curves/tree/master/k256
[RustCrypto/p256]: https://github.com/RustCrypto/elliptic-curves/tree/master/p256
[RustCrypto/p384]: https://github.com/RustCrypto/elliptic-curves/tree/master/p384
[Dfns/stark]: https://github.com/LFDT-Lockness/stark-curve/
[curve25519-dalek]: https://docs.rs/curve25519-dalek/
[ed448-goldilocks-plus]: https://crates.io/crates/ed448-goldilocks-plus

In order to use one of the supported curves, you need to turn on corresponding feature. E.g. if you want
to use secp256k1 curve, add this to Cargo.toml:
Expand Down
7 changes: 7 additions & 0 deletions generic-ec-curves/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,18 @@ sha2 = { workspace = true, optional = true }
stark-curve = { version = "0.1", default-features = false, optional = true }

group = { version = "0.13", default-features = false, optional = true }
generic-array = { workspace = true, optional = true }

[dependencies.curve25519]
workspace = true
features = ["group", "zeroize", "rand_core", "precomputed-tables"]
optional = true

[dependencies.ed448-goldilocks-plus]
workspace = true
features = ["zeroize"]
optional = true

[dev-dependencies]
rand.workspace = true
rand_dev.workspace = true
Expand All @@ -43,6 +49,7 @@ secp256r1 = ["rust-crypto", "p256", "sha2"]
secp384r1 = ["rust-crypto", "p384", "sha2"]
stark = ["rust-crypto", "stark-curve", "sha2"]
ed25519 = ["dep:curve25519", "dep:group"]
ed448 = ["dep:ed448-goldilocks-plus", "dep:group", "dep:generic-array"]

[package.metadata.docs.rs]
all-features = true
Expand Down
4 changes: 4 additions & 0 deletions generic-ec-curves/benches/curves.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ fn bench_curves(c: &mut criterion::Criterion) {
bench_curve::<generic_ec_curves::Ed25519>(c, &mut rng, "ed25519");
bench_bytes_reduction::<generic_ec_curves::Ed25519, 32>(c, &mut rng, "ed25519");
bench_bytes_reduction::<generic_ec_curves::Ed25519, 64>(c, &mut rng, "ed25519");

bench_curve::<generic_ec_curves::Ed448>(c, &mut rng, "ed448");
bench_bytes_reduction::<generic_ec_curves::Ed448, 57>(c, &mut rng, "ed448");
bench_bytes_reduction::<generic_ec_curves::Ed448, 114>(c, &mut rng, "ed448");
}

fn bench_curve<E: Curve>(
Expand Down
Loading
Loading