Conversation
Crate direct depsDirect depsCompared to base branchDiffAll depscargo treeCompared to base branchDiff |
|
The spec was successfully compiled. PDF is available here. |
Benchmark ResultBenchmarks |
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Contributor
Author
|
@maurges @nikita-dfns can you look at changes I pushed in 89397b8 before I update all tests to work with HD in similar way? |
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
8 tasks
maurges
reviewed
Mar 20, 2026
maurges
reviewed
Mar 20, 2026
|
Looks good. I actually like the test changes |
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Contributor
Author
|
@maurges pushed suggested changes + reworked the precomputed shares storage. Now it's optimal, we do not store the duplicate information, as result size of file dropped from 401M to 116K. As result, there's more code for key shares reconstruction (as they are stored in disassembled state), but I think it's worth it. |
maurges
reviewed
Mar 23, 2026
maurges
previously approved these changes
Mar 23, 2026
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
maurges
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Size of pregenerated shares is over 400 MB, I had to move it to LFSI noticed that it's very easy to make a mistake and provide wrong security level/digest to secp384r1 curve. Previously, we were always using the same security level/digest pretty much everywhere, but now we have different curves that should be used with different digest/security level.
In next PR, I want to add
trait Suite { type Digest; type Curve; type SecLevel; }and then change api so it takes a cryptosuite instead of curve, e.g.cggmp24::keygen::<cggmp24::suites::Secp256k1>(eid, i, n)cggmp24::keygen::<cggmp24::supported_curves::Secp256k1>(eid, i, n)