Skip to content

Add serde traits for presignature public data and commitment #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alfonzii wants to merge 1 commit into
base: cggmp24/m
Choose a base branch
from
+2 −2
Open

Add serde traits for presignature public data and commitment #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cggmp24/src/signing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ pub struct Presignature<E: Curve> {
/// Public part of the presignature that can be used to verify partial signatures from other parties
///
/// They are used to validate partial signature produced by the signers from a presignature
#[derive(Clone, Debug, PartialEq, Eq)]
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
pub struct PresignaturePublicData<E: Curve> {
Comment on lines +195 to 196
Copy link
Copy Markdown
Contributor

@survived survived Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alone is not sufficient, you also need to add this attribute, otherwise derived trait impl will be unusable

Suggested change
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
pub struct PresignaturePublicData<E: Curve> {
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(bound = "")]
pub struct PresignaturePublicData<E: Curve> {

/// $\Gamma$ presignature commitment
pub Gamma: NonZero<Point<E>>,
Expand All @@ -201,7 +201,7 @@ pub struct PresignaturePublicData<E: Curve> {
}

/// Presignature commitment, used to verify partial signature correctness
#[derive(Clone, Debug, PartialEq, Eq)]
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
Copy link
Copy Markdown
Contributor

@survived survived Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

pub struct PresignatureCommitment<E: Curve> {
/// $\tilde \Delta_j$
pub tilde_Delta: Point<E>,
Expand Down
Loading