Skip to content

BananaMath and WeatherAPI#88

Open
cb1658 wants to merge 10 commits intoLEAGUE-Level6:developmentfrom
cb1658:feature1
Open

BananaMath and WeatherAPI#88
cb1658 wants to merge 10 commits intoLEAGUE-Level6:developmentfrom
cb1658:feature1

Conversation

@cb1658
Copy link

@cb1658 cb1658 commented Sep 17, 2025

The two features in this code include:

  • A simple math calculator which is activated with keywords.
  • A "weather" feature which uses an API and can recall the weather of any city or zip code.

Copy link

@123456789degrees 123456789degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality is fine, variables could be more specific.

switch(things[0].toLowerCase()) {

case "add":
String a;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variables could be more specific

else if(messageContent.toLowerCase().startsWith(COMMAND) && BananaMode) {

String t = messageContent.substring(7); // good
String[] things = t.trim().split(" ");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variables could be more specific

try {
Thread.sleep(r.nextInt(3500)+500);

event.sendResponse("Loading... [--- ] 20%");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this loading thing doesnt really show correctly on discord


//String json = getCurrentWeather(city);

CurrentWeather actualObject = getCurrentWeather2(city);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also bad variable name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants