Open
Conversation
…I, issue appears when sending them. created embed with no errors, but no images actually appear? make sure sizes are right?
…e to get it to work, but should be nice still. Can't get image to properly embed at all.
…that the data gets sent only if the suer wants it andthe rest of the message was semi-recent.
…MessagesWithCommand test fails constantly.
… is really wierd but found info online. rest is good.
cb1658
reviewed
Sep 25, 2025
|
|
||
| EmbedBuilder eb = new EmbedBuilder(); | ||
| ArrayList<String> data = getAPODData(); | ||
| eb.setAuthor("Photographer: " + data.get(2)); |
|
|
||
| if (!(featureThree instanceof Feature)) { | ||
| assertNotEquals("!command", command); | ||
| } |
123456789degrees
left a comment
123456789degrees
left a comment
There was a problem hiding this comment.
Functionality is good. The test coverage is 100% nice.
|
|
||
| public class FeatureThree extends Feature { | ||
|
|
||
| private static final String baseUrl = "https://api.nasa.gov/planetary/apod?api_key=" + System.getenv("API_KEY"); |
There was a problem hiding this comment.
It doesnt work without the api key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature accesses the NASA Astronomy Photo Of the Day API (APOD), and provides a quite pretty image of space/astronomy related things. Use the command !SpacePic to call this feature. Additionally, you can have additional information about the photo if you respond when prompted. 100% coverage on the main class, 66% coverage on the POJO handler (I'm not sure if that needs 100%/ how to get it there).