Skip to content

Feature1/richardson liou#79

Open
richardson-liou wants to merge 15 commits intoLEAGUE-Level6:developmentfrom
richardson-liou:feature1/richardson-liou
Open

Feature1/richardson liou#79
richardson-liou wants to merge 15 commits intoLEAGUE-Level6:developmentfrom
richardson-liou:feature1/richardson-liou

Conversation

@richardson-liou
Copy link

Richardson Liou - First feature

Copy link

@opie10 opie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to modify the code in order to check coverage with tests. Tests do not seem to compile as FeatureTemplateTest/FeatureTemplate has been changed a lot and doesn't have a constructor or base command to do tests. Not all features are fully covered, eg. featureOne has 100% method coverage and 52% line coverage. Feature Two (WordChain) only has 60% method coverage, with no tests to verify the actual play of the game. The 3rd feature has 0% coverage, which might be fair due to its complexity, however I would recommend creating a test which at least checks that there is a help embed and that it will. Main issue is tests, which don't compile on my machine. One final thing is that the API key is available in the source code and not protected, but IDK how big of a deal that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants