Feature1/richardson liou#79
Feature1/richardson liou#79richardson-liou wants to merge 15 commits intoLEAGUE-Level6:developmentfrom
Conversation
Change the findRecipe to throw
opie10
left a comment
There was a problem hiding this comment.
I had to modify the code in order to check coverage with tests. Tests do not seem to compile as FeatureTemplateTest/FeatureTemplate has been changed a lot and doesn't have a constructor or base command to do tests. Not all features are fully covered, eg. featureOne has 100% method coverage and 52% line coverage. Feature Two (WordChain) only has 60% method coverage, with no tests to verify the actual play of the game. The 3rd feature has 0% coverage, which might be fair due to its complexity, however I would recommend creating a test which at least checks that there is a help embed and that it will. Main issue is tests, which don't compile on my machine. One final thing is that the API key is available in the source code and not protected, but IDK how big of a deal that is.
Richardson Liou - First feature