Feature One !introduce Feature Two !blackjack#74
Open
NicholasFal wants to merge 13 commits intodevelopmentfrom
Open
Feature One !introduce Feature Two !blackjack#74NicholasFal wants to merge 13 commits intodevelopmentfrom
NicholasFal wants to merge 13 commits intodevelopmentfrom
Conversation
YeetMaster467
requested changes
May 22, 2025
Collaborator
YeetMaster467
left a comment
YeetMaster467
left a comment
There was a problem hiding this comment.
Overall good features, some features are intertangled with others (i.e. HighLow and Blackjack) You should also provide more clarity in naming your classes. Other than those your code looks pretty good. 👍
| addFeature(new NewsApi(channelName)); | ||
| addFeature(new CatFactsApi(channelName)); | ||
| //MINE | ||
| addFeature(new FeatureOne(channelName)); |
Collaborator
There was a problem hiding this comment.
Add distinct names for your features, if someone else uses the name FeatureOne etc. they could override yours.
| public class HighLowGame extends Feature { | ||
|
|
||
| public final String COMMAND = "!highLow"; | ||
| public final String COMMAND = "!HighLowGame"; |
Collaborator
There was a problem hiding this comment.
Separate your blackjack from your HighLowGame. Even though you have your own blackjack class, you should remove the elements of blackjack from HighLow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bot will introduce itself and explain what it can do.
Play a game of blackjack with the bot where your goal is to get as close as possible to 21 by drawing random cards. Try to see if you can beat the bot! Write !blackjack to start, !blackjack hit to hit, and !blackjack stand to stand.