Skip to content

Feature/samus114#193

Open
SKempiak wants to merge 4 commits intodevelopmentfrom
feature/samus114
Open

Feature/samus114#193
SKempiak wants to merge 4 commits intodevelopmentfrom
feature/samus114

Conversation

@SKempiak
Copy link
Collaborator

@SKempiak SKempiak commented Apr 8, 2021

No description provided.

@Sofisa
Copy link
Collaborator

Sofisa commented Apr 12, 2021

Hi Samson! I reviewed your code for DnDCompanion and it was great.
There are a couple of issues I noticed:

  • this isn't a valid link - http://ro1120.net/ (I think you used 1 as l)
  • maybe clear up the instructions and have a !help or /help
  • putting a negative number (I know it's stupid) for the dice sides break your code
  • discord call isn't available
    Otherwise really solid and would use if I knew how to play DnD ̿̿ ̿̿ ̿̿ ̿'̿'\̵͇̿̿\з= ( ▀ ͜͞ʖ▀) =ε/̵͇̿̿/’̿’̿ ̿ ̿̿ ̿̿ ̿̿

@SKempiak SKempiak requested review from Drill-X and mjfre April 22, 2021 00:18
@SKempiak SKempiak changed the title Feature/compareBrand Feature/samus114 May 6, 2021
@SKempiak
Copy link
Collaborator Author

fixed the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants