Open
Conversation
zhaoyongjie
reviewed
Mar 16, 2023
kylinpy/service/kylin_service.py
Outdated
Comment on lines
+140
to
+145
| try: | ||
| response = self.client.post('/saved_queries', **kwargs).json() | ||
| except InternalServerError as err: | ||
| raise KylinQueryError(err) | ||
|
|
||
| return response |
Contributor
There was a problem hiding this comment.
Hi @yqkcn, thanks for adding new API support in Kylinpy, I'll add the first quick pass review.
The KylinQueryError refers to a query that is incorrect or unreachable so a normal API shouldn't be raised for that one.
On the other hand, the KylinQueryError also be used in catching a bad query on the upstream use case.
Contributor
Author
There was a problem hiding this comment.
OK, I will add some Error Inherit from KylinError, and also add some unit tests.
yqkcn
changed the title
yqkcn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cwiki.apache.org/confluence/display/KYLIN/Query+API